Repository navigation
ci: run on Node.js 24.22.1 and 22.23.4 instead of end-of-life Node.js 20 - #29
Merged
Merged
Conversation
Node.js 20 is end-of-life and gets no fix for the October 2026 security release. Build, test and pack now use 24.22.1. The platform smoke tests use 22.23.4, the oldest Node.js line that still gets security fixes. No package change. The addon uses N-API, and none of these CVEs touch N-API. engines still says ">= 18".
Affan Dar (affandar)
changed the title
Affan Dar (affandar)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 20 is end-of-life. It gets no fix for the October 2026 Node.js security release. CI used Node.js 20 in every job: the latest run downloaded 20.20.2.
Change
.github/workflows/build.yml:24.22.1 and 22.23.4 are the patched releases. 22.23.4 is the oldest Node.js line that still gets security fixes, so the smoke tests still test the oldest supported line.
CHANGELOG.mdgets an Unreleased entry.No package change and no release needed. The addon uses N-API, and none of these CVEs touch N-API.
enginesstill says">= 18"; raising it is a separate decision.Tested
Locally on darwin-arm64, with the official Node.js builds (checksums verified):
npm run test:allci/smoke/run-local.shon packed 0.2.2 tarballsThis PR's CI run covers the other platforms.